Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature 9125: Fix top menu for mobile screens #9143

Merged
merged 9 commits into from Aug 24, 2023
Merged

feature 9125: Fix top menu for mobile screens #9143

merged 9 commits into from Aug 24, 2023

Conversation

khangon
Copy link
Contributor

@khangon khangon commented Aug 18, 2023

Fixes #9125

Short description of what this resolves:

Fix top menu for mobile screens

Changes proposed in this pull request:

  • Fix top menu for mobile screens

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ❌ Failed (Inspect) Aug 22, 2023 10:11am

@khangon
Copy link
Contributor Author

khangon commented Aug 18, 2023

Hi @norbusan , @mariobehling , @cweitat ,
We have completed ticket #9125
Please help me check and verify.
Thanks,
Screenshot from 2023-08-18 14-49-26

Screenshot from 2023-08-18 14-49-48

@khangon khangon marked this pull request as ready for review August 18, 2023 08:39
@mariobehling
Copy link
Member

Please centre "Exhibition" in the column as well.

@khangon
Copy link
Contributor Author

khangon commented Aug 21, 2023

Please centre "Exhibition" in the column as well.

Hi @mariobehling ,
We have fixed. Please help me review. Thanks!
Screenshot from 2023-08-21 09-46-51

mariobehling
mariobehling requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please center the "open event" logo on the top right.

@khangon
Copy link
Contributor Author

khangon commented Aug 22, 2023

Please center the "open event" logo on the top right.

Hi @mariobehling,
I have fixed this issue. Please help me check it.
Thanks

image

@mariobehling mariobehling merged commit 25ab4c1 into fossasia:development Aug 24, 2023
7 of 8 checks passed
norbusan pushed a commit that referenced this pull request Mar 26, 2024
@khangon @ntthitrinh @norbusan
feature 9125: Fix top menu for mobile screens (#9143)
b8ff238 
* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

---------

Co-authored-by: ntthitrinh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix top menu for mobile screens
4 participants
@khangon @mariobehling @ntthitrinh @odkhang